-
Notifications
You must be signed in to change notification settings - Fork 0
KAFKA-19173: Add Feature
for "streams" group
#5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -368,7 +368,7 @@ public void testInvalidFeatureFlag() throws Exception { | |
formatter1.formatter.setFeatureLevel("nonexistent.feature", (short) 1); | ||
assertEquals("Unsupported feature: nonexistent.feature. Supported features " + | ||
"are: eligible.leader.replicas.version, group.version, kraft.version, " + | ||
"share.version, test.feature.version, transaction.version", | ||
"share.version, streams.group.featrue, test.feature.version, transaction.version", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Documentation Issue: There's a typo in the feature name 'streams.group.featrue' (should be 'streams.group.version') in the FormatterTest error message. This inconsistency between the actual feature name defined in StreamsGroupVersion.java ( |
||
assertThrows(FormatterException.class, | ||
() -> formatter1.formatter.run()). | ||
getMessage()); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.kafka.server.common; | ||
|
||
import java.util.Map; | ||
|
||
public enum StreamsGroupVersion implements FeatureVersion { | ||
|
||
// Version 0 does disable "streams" groups (KIP-1071). | ||
SGV_0(0, MetadataVersion.MINIMUM_VERSION, Map.of()), | ||
|
||
// Version 1 enables "streams" groups (KIP-1071). | ||
SGV_1(1, MetadataVersion.IBP_4_1_IV2, Map.of()); | ||
|
||
public static final String FEATURE_NAME = "streams.group.version"; | ||
|
||
// Disabled by default in 4.1 (early access only). | ||
public static final StreamsGroupVersion LATEST_PRODUCTION = SGV_0; | ||
|
||
private final short featureLevel; | ||
private final MetadataVersion bootstrapMetadataVersion; | ||
private final Map<String, Short> dependencies; | ||
|
||
StreamsGroupVersion( | ||
int featureLevel, | ||
MetadataVersion bootstrapMetadataVersion, | ||
Map<String, Short> dependencies | ||
) { | ||
this.featureLevel = (short) featureLevel; | ||
this.bootstrapMetadataVersion = bootstrapMetadataVersion; | ||
this.dependencies = dependencies; | ||
} | ||
|
||
@Override | ||
public short featureLevel() { | ||
return featureLevel; | ||
} | ||
|
||
@Override | ||
public String featureName() { | ||
return FEATURE_NAME; | ||
} | ||
|
||
@Override | ||
public MetadataVersion bootstrapMetadataVersion() { | ||
return bootstrapMetadataVersion; | ||
} | ||
|
||
@Override | ||
public Map<String, Short> dependencies() { | ||
return dependencies; | ||
} | ||
|
||
public boolean streamsGroupSupported() { | ||
return featureLevel >= SGV_1.featureLevel; | ||
} | ||
|
||
public static StreamsGroupVersion fromFeatureLevel(short version) { | ||
return switch (version) { | ||
case 0 -> SGV_0; | ||
case 1 -> SGV_1; | ||
default -> throw new RuntimeException("Unknown streams group feature level: " + (int) version); | ||
}; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typo in feature name in error message.
There's a typo in the feature name included in the error message: "streams.group.featrue" should be "streams.group.version" to match the actual feature name used elsewhere in the codebase.
📝 Committable suggestion