feat(installer): support templated install configs from vault#457
Merged
Conversation
Render install config templates through a shared configtemplating package. Add vault-backed secret lookup with explicit vault path handling for install and bootstrap flows. Signed-off-by: Tim Schrodi <tim@codesphere.com>
Signed-off-by: schrodit <7979201+schrodit@users.noreply.github.com>
joka134
requested changes
Jun 1, 2026
joka134
left a comment
Member
There was a problem hiding this comment.
nice feature! 🚀 Left some comments. Let's discuss it if you want
- rename `oms config template` -> `oms template config` for verb-first consistency with other commands - rename RenderConfigFileToTempIfNeeded -> RenderConfigFileToTemp (always creates a temp file) - extract lazy vault loading into ensureVault() with clearer error messages and drop the redundant nil-receiver check - add doc comments to exported templating/secret-store APIs - warn that `template config` prints secrets to stdout - tidy config template test payload and regenerate docs Signed-off-by: Tim Schrodi <tim@codesphere.com>
joka134
requested changes
Jun 2, 2026
joka134
left a comment
Member
There was a problem hiding this comment.
Nice! added some optional comments. But adding some examples to the CLI would simplify the usage.
Signed-off-by: schrodit <7979201+schrodit@users.noreply.github.com>
joka134
reviewed
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{{ secret "..." }}lookups backed byprod.vault.yaml{{ vault.mySecret.password }}because using a function make it more generic to support other stores like vault ehre secrets are rather fetched async.configtemplatingpackage and a vault-backed installer secret storeoms install codesphere --vault0600files and warn whensecrets.baseDirdiffers from the passed vault directoryExample
Use the newly added
oms config templatecommand to test it out locally.