Allow adding a large product #1075
+417
−46
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| package org.codice.ddf.catalog.ui.util.jaxrs; | ||
|
|
||
| import java.util.*; | ||
|
|
||
| import javax.ws.rs.core.Cookie; | ||
| import javax.ws.rs.core.HttpHeaders; | ||
| import javax.ws.rs.core.MediaType; | ||
| import javax.ws.rs.core.MultivaluedHashMap; | ||
| import javax.ws.rs.core.MultivaluedMap; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
| import spark.Request; | ||
|
|
||
| public class JaxRsHttpHeaders implements HttpHeaders { | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(JaxRsHttpHeaders.class); | ||
| private final Request sparkRequest; | ||
|
|
||
| public JaxRsHttpHeaders(Request sparkRequest) { | ||
| this.sparkRequest = sparkRequest; | ||
| } | ||
|
|
||
| @Override | ||
| public List<String> getRequestHeader(String name) { | ||
| String header = sparkRequest.headers(name); | ||
| return header != null ? Collections.singletonList(header) : Collections.emptyList(); | ||
| } | ||
|
|
||
| @Override | ||
| public String getHeaderString(String s) { | ||
| LOGGER.warn("Not implemented: JaxRsHttpHeaders.getHeaderString()"); | ||
|
There was a problem hiding this comment. Does it make sense to throw a "NotImplementedException"? |
||
| return ""; | ||
| } | ||
|
|
||
| @Override | ||
| public MultivaluedMap<String, String> getRequestHeaders() { | ||
| LOGGER.warn("Not implemented: JaxRsHttpHeaders.getRequestHeaders()"); | ||
| return new MultivaluedHashMap<>(); | ||
| } | ||
|
|
||
| @Override | ||
| public List<MediaType> getAcceptableMediaTypes() { | ||
| LOGGER.warn("Not implemented: JaxRsHttpHeaders.getAcceptableMediaTypes()"); | ||
| return List.of(); | ||
| } | ||
|
|
||
| @Override | ||
| public List<Locale> getAcceptableLanguages() { | ||
| LOGGER.warn("Not implemented: JaxRsHttpHeaders.getAcceptableLanguages()"); | ||
| return List.of(); | ||
| } | ||
|
|
||
| @Override | ||
| public MediaType getMediaType() { | ||
| LOGGER.warn("Not implemented: JaxRsHttpHeaders.getMediaType()"); | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public Locale getLanguage() { | ||
| LOGGER.warn("Not implemented: JaxRsHttpHeaders.getLanguage()"); | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public Map<String, Cookie> getCookies() { | ||
| LOGGER.warn("Not implemented: JaxRsHttpHeaders.getCookies()"); | ||
| return Map.of(); | ||
| } | ||
|
|
||
| @Override | ||
| public Date getDate() { | ||
| LOGGER.warn("Not implemented: JaxRsHttpHeaders.getDate()"); | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public int getLength() { | ||
| LOGGER.warn("Not implemented: JaxRsHttpHeaders.getLength()"); | ||
| return 0; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually it is bad practice to embed bundles. I would expect that the rest endpoint classes you are trying to access would be available within the OSGI service registry and so embedding this jar shouldn't be necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, we should not be embedding this bundle here as it will likely cause unintended consequences. Also see my other comments on its use later as this shouldn't be needed.