Skip to content

Repo hardening: fix install instructions, dead imports, hygiene#2

Open
cognis-digital wants to merge 4 commits into
mainfrom
cognis-audit/repo-hardening
Open

Repo hardening: fix install instructions, dead imports, hygiene#2
cognis-digital wants to merge 4 commits into
mainfrom
cognis-audit/repo-hardening

Conversation

@cognis-digital

@cognis-digital cognis-digital commented Jun 12, 2026

Copy link
Copy Markdown
Owner

This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:

  • fix 2 broken pip install line(s) in README (package is not on PyPI; use the working git+https install)
  • remove 3 unused import(s) (ruff F401/F811)

Each change is deterministic; all touched Python files were confirmed to still compile (py_compile) before this PR was opened.

- fix 2 broken `pip install` line(s) in README (package is not on PyPI; use the working git+https install)
- remove 3 unused import(s) (ruff F401/F811)
@cognis-digital
cognis-digital force-pushed the cognis-audit/repo-hardening branch from 33fc022 to c515ac3 Compare June 12, 2026 21:55
Cognis Digital added 3 commits June 13, 2026 04:13
- core.py: add TOOL_NAME/TOOL_VERSION constants; validate lat/lon range
  (-90..90, -180..180) in AISMessage.from_dict; raise clear ValueError on
  empty or unparseable timestamps; wrap per-record errors with index in
  parse_messages; catch UnicodeDecodeError in load_messages; fix long line
  in detect_spoofing
- cli.py: validate positive-float numeric args (--gap-hours, --max-speed-kn,
  --radius-nm, --min-hours, --proximity-nm, --min-minutes) before loading
  data — exits 2 with a clear message on bad values; fix ruff E741
  ambiguous variable name `l`
- tests/test_hardening.py: 34 new tests covering missing fields, out-of-range
  coords, bad timestamps, malformed JSON, wrong top-level type, empty
  collections, single-message tracks, and all CLI bad-arg paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant