Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: underlined text in homepage cards #400

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: underlined text in homepage cards #400

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d012cc0
fix: underlined text in homepage cards
Feb 5, 2025
3bbc193
Merge branch 'main' into fix-underline-home-cards
fern-support Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions fern/pages/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export const LandingPageCard = ({ href, title, imgSrc, description }) => (
href={href}
target="_self"
className="flex h-full flex-col justify-between"
style={{ textDecoration: 'none' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: instead of using inline style we can use tailwind class no-underline, it will also remove text underline

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tailwind doesn't work in this scenario, there's an issue with tailwind loading. We will fix this at a platform level soon :).

For an immediate fix, this is the only solve!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see, okay

>
<div className="mb-5 flex flex-col justify-between gap-5">
<h2 className="lg:min-h-20 [@media(min-width:1181px)]:min-h-0">
Expand Down
Loading