Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix isort and black conflict #71

Merged
merged 1 commit into from
Nov 22, 2022
Merged

fix isort and black conflict #71

merged 1 commit into from
Nov 22, 2022

Conversation

yichern
Copy link
Contributor

@yichern yichern commented Nov 22, 2022

What this PR does

  • Fixes an isort and black conflict in pre-commit hook

This issue arises in this example:

from datetime import date

from cost_categories import (
    applsj,
    asjdfsi,
    bananana,
    sdjffsd,
    sjdifjsl,
    sjdil,
    yoyoyoyoy,
)
from library_user import User

taken from PyCQA/isort#1518

How it was tested

  • isort follows black style for the above example

PR checklist

  • No API keys or other secrets committed to source?
  • New functionality is added alongside appropriate tests?
  • All source files have the following header?
# Copyright (c) {YEAR} Cohere Inc. and its affiliates.
#
# Licensed under the MIT License (the "License");
# you may not use this file except in compliance with the License.
#
# You may obtain a copy of the License in the LICENSE file at the top
# level of this repository.

@yichern yichern requested a review from a team November 22, 2022 06:54
@yichern yichern self-assigned this Nov 22, 2022
@yichern yichern added the bug Something isn't working label Nov 22, 2022
@yichern yichern marked this pull request as ready for review November 22, 2022 06:54
Copy link
Contributor

@madelinehjenkins madelinehjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me! Thank you for fixing this.

@yichern yichern merged commit ffb862f into main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants