-
Notifications
You must be signed in to change notification settings - Fork 2
comprehensive SDK update with new endpoints and OpenAPI spec alignment #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
src/CoinbaseSdk/PrimeExample/examples/activities/GetActivity.cs
Outdated
Show resolved
Hide resolved
5f344b2 to
4aa5abf
Compare
src/CoinbaseSdk/PrimeExample/examples/activities/GetActivity.csx
Outdated
Show resolved
Hide resolved
src/CoinbaseSdk/PrimeExample/examples/wallets/ListWalletAddresses.csx
Outdated
Show resolved
Hide resolved
cfluke-cb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a Paginated Request base class to handle Cursor and Limit? they are consistent across api.
SortDirection is in some places, and not others. your discretion to put in PaginatedRequest as optional or not
rcbgr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add the following header to the .net and java SDKs for all requests
prime-sdk-java|dotnet/$version
src/CoinbaseSdk/Prime/activities/GetPortfolioActivityRequest.cs
Outdated
Show resolved
Hide resolved
2723659 to
486ddd0
Compare
a7b4a8c to
4ca5958
Compare
src/CoinbaseSdk/Prime/futures/GetFcmMarginCallDetailsResponse.cs
Outdated
Show resolved
Hide resolved
src/CoinbaseSdk/Prime/onchainaddressgroups/IOnchainAddressGroupsService.cs
Outdated
Show resolved
Hide resolved
119d00c to
a8b72ea
Compare
da422c7 to
16df2a7
Compare
add/update examples
Wallets examples
add orders examples
Transactions examples
add financing/futures examples and generate models for them
More examples
Summary
Comprehensive update to the Coinbase Prime .NET SDK bringing it to v0.4.0 with complete API coverage, full alignment with the OpenAPI specification, and enhanced HTTP client functionality.
Key Changes
HTTP Client Enhancements
SdkVersionwith dynamic assembly version extractionUser-Agent: prime-sdk-dotnet/{version}header using actual package version (0.4.0)PaginatedRequest Base Class Implementation
PaginatedRequestabstract base class with standardizedCursorandLimitpropertiesPaginatedRequestBuilder<T,TBuilder>generic base class for type-safe fluent pagination APIIntegerCursorPaginatedRequestfor special case handling (ListInvoicesRequest uses int? cursor)New API Endpoints
OrdersService.EditOrder- Modify existing order parametersActivitiesService.GetActivity- Retrieve individual activity detailsFuturesService.GetFcmMarginCallDetails/GetFcmRiskLimits- FCM trading supportWalletsService.GetWallet/CreateWalletDepositAddress/ListWalletAddresses- Enhanced wallet managementStakingService.CreatePortfolioStake/CreatePortfolioUnstake- Portfolio staking operationsBalancesService.ListWeb3WalletBalances- Web3 wallet integrationOnchainAddressGroupsService- Complete onchain address group managementOpenAPI Spec Alignment
ActivityCategory,ActivityStatus,ActivityLevel,SortDirection,TransactionTypeenumsMethod Renaming
GetActivityByActivityId→GetActivityGetPortfolioAddressBook→ListAddressBookEntriesGetPortfolioById→GetPortfolioGetTransactionByTransactionId→GetTransactionTesting Infrastructure
CoinbaseSdk.Prime.Testsproject with comprehensive test coverageExamples
Documentation
Test Plan