Chore: cleanup repo for oss publish.#18
Conversation
✅ Heimdall Review Status
|
Code Review — PR #18 (Chore: cleanup repo for OSS publish)OverviewThree concerns rolled into one cleanup PR ahead of OSS publish:
Net Code quality
Issues / suggestions1. Dangling subheading in top-level README (minor, doc bug) The "Implementation-specific features" line is a header with no content beneath it before the next H2 — readers will see a label that promises a list and then immediately jumps to the implementations table. Either inline a one-line pointer ("See each implementation's README below.") or drop the line entirely. 2. Solana CI:
3. Solana CI: no fmt/clippy/test gating beyond 4. Solana CI: 5. 6. Risks
VerdictLGTM with the README dangling-subheading fix and the CI caching note worth addressing before merge. Other items are non-blocking polish. |
| - **Pause Controls** -- Independent toggles for swap and liquidity operations | ||
| - **Slippage Protection** -- Users specify a minimum output amount per swap | ||
|
|
||
| Implementation-specific features (see each README for details): |
|
|
||
| - name: Build Anchor program | ||
| working-directory: solana | ||
| run: anchor build |
There was a problem hiding this comment.
any formatting needed before the build like in evm?
9dbd982
Description
Type of Change
Checklist