Bugfix: Check if ColdboxVirtualApp Exists Before Shutdown #28
Conversation
If you set `this.unLoadColdbox = true; ` in your tests, there won't be a `ColdboxVirtualApp` in the `request` scope and the page will throw an exception "The key [COLDBOXVIRTUALAPP] does not exist in the request scope, the structure is empty"
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the onRequestEnd method in the test harness throws an exception when this.unLoadColdbox = true is set in tests. The fix adds a defensive check to verify the existence of coldBoxVirtualApp in the request scope before attempting to call its shutdown method.
Changes:
- Added conditional check in
onRequestEndto prevent exception whencoldBoxVirtualAppis not in the request scope
| request.coldBoxVirtualApp.shutdown(); | ||
| } |
There was a problem hiding this comment.
The indentation uses spaces but this project is configured to use tabs for indentation (see .cfformat.json). The if block and its contents should be indented with tabs to match the project's formatting standards.
| request.coldBoxVirtualApp.shutdown(); | |
| } | |
| request.coldBoxVirtualApp.shutdown(); | |
| } |
|
|
||
| public void function onRequestEnd( required targetPage ) { | ||
| request.coldBoxVirtualApp.shutdown(); | ||
| if ( request.keyExists( "coldBoxVirtualApp" ) ) { |
There was a problem hiding this comment.
There is an extra space in the keyExists function call. It should be request.keyExists( "coldBoxVirtualApp" ) instead of request.keyExists( "coldBoxVirtualApp" ) to match the project's formatting standards which use single spaces for padding.
| if ( request.keyExists( "coldBoxVirtualApp" ) ) { | |
| if ( request.keyExists( "coldBoxVirtualApp" ) ) { |
1 participant
If you set
this.unLoadColdbox = true;in your tests, there won't be aColdboxVirtualAppin therequestscope and the page will throw an exception "The key [COLDBOXVIRTUALAPP] does not exist in the request scope, the structure is empty"Type of change
Checklist