Cleanup Testing & Retry logic #3477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaoyi
changed the title
lihaoyi
changed the title
Merged
lihaoyi
added a commit
that referenced
this pull request
Sep 8, 2024
This should pull in #3477 and help resolve the flakiness we are still seeing at during the compilation of Mill, as the fixes in master were not yet taking effect yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mill.api.Retryhelper, add some minimal unit tests, and use it throughout Milllambdatestforjunitso we can use the standard JUnit retry facilities onFileToStreamTailerTest(nothing built in, but googling brings up lots of examples to copy-paste)os.temp.dirfrom Integration testerworkspacePathand replace it with a shorterrun-$ifolder that serves the same purposeout/folder to force the processes to terminate