Addresses #111 by adding a local API proxy #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmakesgames
requested changes
Jan 23, 2021
| const app = express() | ||
| const port = 1337 | ||
| const debug = true | ||
| const proxy = debug |
There was a problem hiding this comment.
Would be nice if this wasn't on by default, otherwise how would we have found #111 -
There was a problem hiding this comment.
It is only enabled when debug is enabled and when the window.location is not hackmud.com.
If we want debug and proxy to be configurable, it probably makes sense to extract them to a config file/envvars/cmdline flags before making them default false.
What's the most common way to provide config to NodeJS apps? I'll implement whichever is more familiar. (I change the default port too, so it'll be handy)
There was a problem hiding this comment.
There are a handful of options. Here are a few:
- modifying package.json (and reading config out of there)
- new .json file in the root
- new config.js file that is referenced in the file via package require (allows for programmatic stuff to happen more than pure key-values)
I think we should probably do 2. for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.