Skip to content

VAE handle HIP OOM exceptions #7764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

VAE handle HIP OOM exceptions #7764

wants to merge 2 commits into from

Conversation

alexheretic
Copy link
Contributor

@alexheretic alexheretic commented Apr 23, 2025 •
edited
Loading

Enhance VAE encode/decode exception handling to treat RuntimeException "HIP error: out of memory" the same as OOM_EXCEPTION.

Resolves #7761

My python isn't so polished so feel free to rewrite this or implement this any other way. Possibly this style should replace all except OOM_EXCEPTION: usages, so they can all handle HIP OOM, but I just did VAE here as this solves my immediate problem.

@alexheretic
Copy link
Contributor Author

This also means I can use Load Clip/device = default instead of "cpu", since the OOM is now handled and tiled vae works.

Perhaps WanImageToVideo should have a tiled option somehow too.

@alexheretic alexheretic mentioned this pull request Apr 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comfyanonymous comfyanonymous Awaiting requested review from comfyanonymous comfyanonymous is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WanImageToVideo: HIP error: out of memory
1 participant
@alexheretic