Skip to content

implement minification in in the makefile #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Conversation

mateusfccp
Copy link
Contributor

@mateusfccp mateusfccp commented Apr 21, 2024

Fixes #63

This reduces the total size of the static assets from 77.39kB to 44.56kB (about 57% of the original size).

Also, as we are bundling together the CSS files, we reduce the number of requests by one, which should be marginally faster.

@mateusfccp mateusfccp requested a review from ryukinix April 21, 2024 16:45
Signed-off-by: Mateus Felipe C. C. Pinto <[email protected]>
@mateusfccp mateusfccp force-pushed the minify_static_assets branch from 508710f to 443aef4 Compare April 21, 2024 16:48
Copy link
Member

@ryukinix ryukinix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for another contribution. I wrote a small suggestion, give a look.

Copy link
Member

@ryukinix ryukinix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryukinix ryukinix merged commit b4d4d35 into master Apr 22, 2024
@ryukinix ryukinix deleted the minify_static_assets branch April 22, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Não estamos mais servindo arquivos minificados
2 participants