Skip to content

Conversation

@tremor021
Copy link
Member

✍️ Description

  • Now uses setup_mariadb_db helper function to create database
  • Harmonize PHP modules installed with Dockerfile
  • Now uses import_local_ip helper function to get current LXC IP address
  • Code cleanup

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@tremor021 tremor021 requested a review from a team as a code owner December 2, 2025 11:33
@tremor021 tremor021 self-assigned this Dec 2, 2025
@github-actions github-actions bot added refactor update script A change that updates a script labels Dec 2, 2025
CrazyWolf13
CrazyWolf13 previously approved these changes Dec 2, 2025
@tremor021
Copy link
Member Author

I have no clue if app actually uses lsb-release for anything... Its not needed for the script thats for sure....

@MickLesk MickLesk merged commit 0f1db8c into community-scripts:main Dec 2, 2025
2 checks passed
jniles pushed a commit to jniles/ProxmoxVE that referenced this pull request Dec 5, 2025
* Refactor

* Update

* Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants