Repository navigation
Conversation
This was referenced Feb 25, 2026
jucor
force-pushed
the
pca_test_cleanup
branch
4 times, most recently
from
February 25, 2026 22:11
8c8f3d9 to
79d6b2f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates Clojure comparison tests following the sklearn PCA implementation from PR #2399. The main goal is to clean up test infrastructure after validating that sklearn PCA matches the Clojure implementation.
Changes:
- Replace PCA Clojure comparison test with pass (validation now covered by regression tests)
- Consolidate Clojure comparison tests into
test_legacy_clojure_regression.pyand delete redundanttest_golden_data.py - Change
@skipmarkers to@xfailfor tests with known differences - Add parallel test execution support with
pytest-xdistgrouping markers - Add
--datasetsCLI option for selective test execution - Standardize imports across test files to use
conftesthelpers
Reviewed changes
Copilot reviewed 21 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test_legacy_clojure_regression.py | Add deprecated PCA comparison test (pass), convert skip to xfail markers, restructure as class-based tests |
| test_golden_data.py | Deleted - redundant with test_legacy_clojure_regression.py |
| test_pca_unit.py | Remove power iteration tests, keep only sklearn PCA tests for NaN handling and edge cases |
| test_pca_edge_cases.py | Remove power iteration edge case tests, keep pca_project_dataframe edge cases |
| test_repness_smoke.py | Standardize imports to use get_available_dataset_params from conftest |
| test_pca_smoke.py | Standardize imports to use get_available_dataset_params from conftest |
| test_legacy_repness_comparison.py | Standardize imports to use get_available_dataset_params from conftest |
| test_conversation_smoke.py | Standardize imports to use get_available_dataset_params from conftest |
| test_regression.py | Add ignore_pca_sign_flip=True to ConversationComparer initialization, add extensive tests for sign flip and scaling detection |
| test_conversation.py | Add recompute=False flags to tests that only validate sorting/moderation (skip unnecessary PCA), add warning filters for sklearn PCA with minimal data |
| test_pipeline_integrity.py | Standardize imports to use make_dataset_params from conftest |
| conftest.py | Add parallel execution helpers (make_dataset_params, get_available_dataset_params), add --datasets CLI option, enhance test filtering |
| pyproject.toml | Add pytest-xdist configuration (--dist=loadgroup) for parallel execution |
| pca.py | Remove ~900 lines of power iteration code, replace with sklearn PCA (from PR #2399) |
| comparer.py | Extensive enhancements for PCA sign flip handling, projection metrics, outlier tolerance |
| datasets.py | Document that get_dataset_info always uses include_local=True |
| regression_recorder.py | Add --include-local option |
| regression_comparer.py | Add PCA-specific options (ignore-pca-sign-flip, outlier-fraction, loose tolerances) |
| bench_pca.py | New benchmark script for PCA performance testing |
| README.md | Document parallel execution and --datasets option |
| regression_testing.md | New comprehensive documentation for regression testing system |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 of 3 tasks
The sklearn PCA implementation has been validated to match Clojure. Regressions are now caught by test_regression.py golden snapshots. This test file will be removed once all other Clojure comparison tests are similarly validated and covered by regression tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ion.py - Delete test_golden_data.py: redundant with test_legacy_clojure_regression.py - Change @Skip to @xfail for test_group_clustering and test_comment_priorities so they run and document expected failures rather than being silently skipped 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This was referenced Mar 5, 2026
1 task done
Collaborator
Author
|
Superseded by #2417 (moved head branch to upstream for simpler stacked PR workflow). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-sklearn cleanup:
Test plan
🤖 Generated with Claude Code