Repository navigation
retire: the tutorial, onboarding and marketing pages - #3293
Merged
Merged
Conversation
Remove POST /api/v3/tutorial and the unused page shells and redirects. No successful request since July 7: the tutorial write, /bot/install*, /bot/support*, /pwreset*, /other-conversations*, /user/create*, /inboxApiTest*, /hk/new*, /s, /s/CTE and /nabi. Some of these registrations were shadowed by broader page routes. Remove the remaining onboarding shells: /createuser*, /user/login*, /user/logout*, /settings*, /conversation/create*, /pwresetinit*, /inbox*, /hk* and /s/*. Remove the marketing and demo pages: /gov*, /company, /contrib*, /demo, /demo/<id> and /bot*. These served successful requests in the September 26 through October 25 access-log window. The aggregate check does not retain their exact last-success timestamps. Remove /about, /football and /pdf redirects. All three returned redirects in that same window; exact last-success timestamps are not in the check. Remove the tutorial CLI operation and docs, legacy demo router entry and analytics mapping, dead tutorial store method, unused page wrappers and redirect helper. Remove the seven matching Rust page handlers, contracts, read settings, nginx switches, health counters and obsolete test fixtures. Retire the 29 stable route identities and check their 404 responses through the real static-file proxy and the generic API fallback. Keep /home, /privacy, /tos, /donate, /signin and /signout. /feeds/*, /api/v3/votes/famous, /polis_site_id*, /report_bundle*, /report_style* and the six topicMod routes stay. No table or column changes; vote, comment and next-statement work is unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
…erver runs, and the differential harness no longer expects the tutorial step Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
The recordings guard requires the route inventory, its scope and its cases to change in a separate pull request from the code they describe; those updates follow once this merges. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
The recordings guard now treats the inventory and scope as the census they are, so the retired entries, scope and cases return to this change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
… page contracts stay out
…er the merge Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
Contributor
Delphi Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove POST /api/v3/tutorial and the unused page shells and redirects.
No successful request since July 7: the tutorial write, /bot/install*,
/bot/support*, /pwreset*, /other-conversations*, /user/create*,
/inboxApiTest*, /hk/new*, /s, /s/CTE and /nabi. Some of these registrations
were shadowed by broader page routes.
Remove the remaining onboarding shells: /createuser*, /user/login*,
/user/logout*, /settings*, /conversation/create*, /pwresetinit*, /inbox*,
/hk* and /s/. Remove the marketing and demo pages: /gov, /company,
/contrib*, /demo, /demo/ and /bot*. These served successful requests
in the September 26 through October 25 access-log window. The aggregate
check does not retain their exact last-success timestamps.
Remove /about, /football and /pdf redirects. All three returned redirects
in that same window; exact last-success timestamps are not in the check.
Remove the tutorial CLI operation and docs, legacy demo router entry and
analytics mapping, dead tutorial store method, unused page wrappers and
redirect helper. Remove the seven matching Rust page handlers, contracts,
read settings, nginx switches, health counters and obsolete test fixtures.
Retire the 29 stable route identities and check their 404 responses through
the real static-file proxy and the generic API fallback.
Keep /home, /privacy, /tos, /donate, /signin and /signout. /feeds/,
/api/v3/votes/famous, /polis_site_id, /report_bundle*, /report_style* and
the six topicMod routes stay.
No table or column changes; vote, comment and next-statement work is unchanged.
CI note: the deletions are one-line registration removals plus their handlers, tests and inventory entries; a table-driven test asserts each retired path now answers 404.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx