Repository navigation
comments: a participant's statement never looks up the owner's account role - #3296
Merged
Merged
Conversation
…t role The old comment path made two external calls to the identity provider on every comment to find the conversation owner's account and read its role. Remove the management client, the owner-role helper, the remaining Pro-gated comment-list branch, and the unused management package. Moderation emails still use the account email stored in the database, and comments still schedule notification tasks. Login configuration is unchanged. The report's moderation level filter, which only applied when the owner carried a paid role, now applies to every conversation; no account is looked up for it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
…without an owner lookup Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
Contributor
Delphi Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reading a conversation's comments for moderation used to look up the conversation owner's account at the identity provider on every request (two calls through the management client, with the client secret in the server) to decide whether the paid-tier moderation level filter applied. A participant's or reader's request never needs the owner's account role.
auth0management package is dropped (nothing else used it).mod_gt, the report's level selector) now applies to every conversation instead of only to owners with the paid role. No account is looked up for it.Tests
npm run buildandnpm run lintclean.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx