Repository navigation
retire: the spam-check client and the permanent-cookie recovery - #3298
Merged
Merged
Conversation
The spam check had not been on the comment path for some time. A source search confirms that Akismet only constructed its client and verified its key at boot. Remove that startup call, dependency, setting, and references. The permanent-cookie recovery had not recovered a participant in a month of production logs. A request with only the old pc cookie and no token now follows the normal first-contact flow and joins as a fresh participant. Keep the database columns and replace the recovery tests with a regression that checks the fresh participant and its signed token. No other code reads req.cookies, so remove the cookie parser too. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
…ow the cookieless server Treat a request with only an old cookie as first contact. Keep both cookie entries in the admission matrix: no external ID follows anonymous entry, and a denied external ID follows new denied-ID entry. Keep both identity cookie cases and record fresh users and participants. The XID case now creates a binding to the new token's user. Preserve JWT verification and the fixture's source hashes. The collective-statement index changes only egress.refusedAtServerLoad: rest.akismet.com:80 is gone because the retired spam-check client no longer verifies its key at startup. All 51 case recordings are unchanged. Two fresh recordings are identical and replay matches byte for byte. Validation on disposable Docker services: all 2,400 admission cases match, all six setup unit tests pass, both identity replays match all 60 cases, and all 123 identity and token tests pass. Both route-inventory hashes still match the source. No runtime or participation-path code changes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
… change after this merges The replay index records which hosts the server tried to reach at load; with the spam-check client gone that list is empty. The recordings guard requires that pin to move in its own change from edge, so it stays as recorded here and follows in a one-line re-record. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
Contributor
Delphi Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spam check had not been on the comment path for some time. A source
search confirms that Akismet only constructed its client and verified its
key at boot. Remove that startup call, dependency, setting, and references.
The permanent-cookie recovery had not recovered a participant in a month
of production logs. A request with only the old pc cookie and no token now
follows the normal first-contact flow and joins as a fresh participant.
Keep the database columns and replace the recovery tests with a regression
that checks the fresh participant and its signed token.
No other code reads req.cookies, so remove the cookie parser too.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx