Repository navigation
Promote edge to stable: Polis 2.43.6 - #3396
Merged
Merged
Conversation
…n whose database predates the migrations, and four reads no longer depend on the migrations' shape (#3393) A second pass of the database tests runs with the older shape installed (json where the migrations build jsonb, another column order). Four reads that failed or handed back there are fixed: the next-comment priorities read and the math generation read take the column's type from the column; the votes and participants reads follow the stored column order, as Node's rows do. Bytes on a database built from the migrations are unchanged. No schema change, no migration, no Node change. Co-authored-by: Claude <noreply@anthropic.com>
The report uses no cookies. A credentialed request is refused by the browser when the API answers Access-Control-Allow-Origin: * to a cross-origin caller, as under the report's development server (port 5010 calling the API on port 5000). Send credentials: "omit", and pin the option with a test. Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
…om any origin is served, with CORS headers for a cookie-free API (#3383) The API reads no cookie and authenticates only with a bearer token, so the allowlist protected nothing that curl could not already reach. A request from an unlisted origin, or one whose Referer names another site, now gets its route's normal answer instead of a 500, in Node and in the Rust API, and the refusal's log line (which wrote every request header) is gone. When a request names an origin (Origin, else Referer) or DOMAIN_OVERRIDE is set, every /api/v3 answer carries Access-Control-Allow-Origin: * with the same allowed headers and methods as before, and no longer Access-Control-Allow-Credentials. A request with neither header gets no CORS headers, as before. The eight DOMAIN_WHITELIST_ITEM settings are removed; nothing reads them. The recorded harnesses all ran with DOMAIN_OVERRIDE set, so every recorded response carried the old headers: the Delphi, identity, treevite and selections recordings are rewritten in place (the origin value and the credentials entry only, digests refreshed), and the collective-statement recordings take ruled expected differences. The POST comments recordings follow in their own change. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…erver sends without the domain allowlist (#3384) * server: the 2013 domain allowlist on /api/v3 is removed; a request from any origin is served, with CORS headers for a cookie-free API The API reads no cookie and authenticates only with a bearer token, so the allowlist protected nothing that curl could not already reach. A request from an unlisted origin, or one whose Referer names another site, now gets its route's normal answer instead of a 500, in Node and in the Rust API, and the refusal's log line (which wrote every request header) is gone. When a request names an origin (Origin, else Referer) or DOMAIN_OVERRIDE is set, every /api/v3 answer carries Access-Control-Allow-Origin: * with the same allowed headers and methods as before, and no longer Access-Control-Allow-Credentials. A request with neither header gets no CORS headers, as before. The eight DOMAIN_WHITELIST_ITEM settings are removed; nothing reads them. The recorded harnesses all ran with DOMAIN_OVERRIDE set, so every recorded response carried the old headers: the Delphi, identity, treevite and selections recordings are rewritten in place (the origin value and the credentials entry only, digests refreshed), and the collective-statement recordings take ruled expected differences. The POST comments recordings follow in their own change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * recordings: the POST comments recordings carry the CORS headers the server sends without the domain allowlist The server no longer refuses any origin and its CORS headers are now Access-Control-Allow-Origin: * with no Access-Control-Allow-Credentials. In every recorded response of the four POST comments golden files, the origin value becomes * and the credentials entry is removed; nothing else changes. These recordings follow the server change in their own pull request because their check refuses a recordings change together with server code, and their expected-differences file cannot name cases across the three recorded profiles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…r and no participant number (#3394) nginx writes the copied vote route's access line with both address fields empty. The shadow's observation line no longer names the comment voted on or the comment it would serve next; the comparison tool reads weeks that hold both line shapes. Node's next-comment log line no longer includes the participant number. No response, header or handler behaviour changes. No schema change, no migration. Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
colinmegill
marked this pull request as ready for review
November 11, 2026 03:43
Contributor
Author
Delphi Coverage Report
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release plan
Version: 2.43.6
Reason: no new selected migrations
Previous stable:
d6b7252492ba0346d58d769d70fe04ad8a45f8f9Candidate:
7b3507d948390730481aa1d05ffa773e88c9c739release.txt additions:
Merge the reviewed version preparation into edge, then refresh this plan for the resulting edge SHA before merging the promotion with a merge commit.