Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge zlib, curl and libxml2 into a single job #829

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Steelskin
Copy link
Collaborator

These 3 jobs are all configured the same way and do not need to be separate jobs each spinning a new build bot instance.

Fixes #825

These 3 jobs are all configured the same way and do not need to be
separate jobs each spinning a new build bot instance.

Fixes #825
.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved
.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved
.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved
.github/workflows/swift-toolchain.yml Outdated Show resolved Hide resolved
@compnerd
Copy link
Owner

compnerd commented Sep 6, 2024

I'm not sure if we want to necessarily merge these into a single job, there is some value in the parallelism still. I was thinking more that we want to merge the Darwin and Windows builds into a single instance rather than a separate set for Darwin and a separate set for Windows.

@Steelskin
Copy link
Collaborator Author

I'm not sure if we want to necessarily merge these into a single job, there is some value in the parallelism still. I was thinking more that we want to merge the Darwin and Windows builds into a single instance rather than a separate set for Darwin and a separate set for Windows.

Ah you would like to re-merge the flows instead? That's something that should be doable after the mac work is finished. I think this is still a good change because this is only consumed by the sdk job, which is happening after the compilers job so we don't get much from parallelization and this should be a bit cheaper to run since we don't need to spawn new instances for every sub-job.

@compnerd
Copy link
Owner

compnerd commented Sep 6, 2024

I am unsure about the merge because I'm thinking that we may want to consume zlib and libxml2 in the compilers build as well, but not CURL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge zlib, curl and libxml2 into a single job
2 participants