Skip to content

feat: add env tradingview #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add env tradingview #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63fa3e9
feat: add env tradingview
Anton-rock Feb 19, 2025
a849b43
feat: add env in workflows
Anton-rock Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .env.develop
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
VITE_FEATURE_TOGGLE_CLIENT_KEY=*:development.7adfb132cb6c86bf5f9e5b35fe5cc72bccdd22b526caccd143007e81
VITE_FEATURE_TOGGLE_CLIENT_KEY=*:development.7adfb132cb6c86bf5f9e5b35fe5cc72bccdd22b526caccd143007e81
NPM_AUTH_TOKEN=
VITE_DATAFEED_URL=https://tv-datafeed.staging.sprk.fi
1 change: 1 addition & 0 deletions .github/workflows/deploy-to-cf-pages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
run: |
touch .env
echo VITE_FEATURE_TOGGLE_CLIENT_KEY=${{ vars.VITE_FEATURE_TOGGLE_CLIENT_KEY }} >> .env
echo VITE_DATAFEED_URL=${{ vars.VITE_DATAFEED_URL }} >> .env
- name: Configure npm authentication for GitHub Registry
env:
NODE_AUTH_TOKEN: ${{secrets.GITHUB_TOKEN}}
Expand Down
6 changes: 1 addition & 5 deletions src/screens/SpotScreen/Chart/TradingViewAdvancedWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React, { useEffect, useRef } from "react";
import { useNavigate } from "react-router-dom";
import { useFlag } from "@unleash/proxy-client-react";
import { observer } from "mobx-react";

import { ChartingLibraryWidgetOptions, LanguageCode, ResolutionString, widget } from "@compolabs/tradingview-chart";
Expand Down Expand Up @@ -55,17 +54,14 @@ const getLanguageFromURL = (): LanguageCode | null => {
};

const TradingViewChartAdvanced = observer(() => {
const isUnderConstruction = useFlag("Trading_view_advance_stagging_");
// const isUnderConstruction = false;

const chartContainerRef = useRef<HTMLDivElement>() as React.MutableRefObject<HTMLInputElement>;
const { tradeStore, mixPanelStore, accountStore } = useStores();
const bcNetwork = FuelNetwork.getInstance();
const navigate = useNavigate();
const defaultProps: Omit<ChartContainerProps, "container"> = {
symbol: tradeStore.market?.symbol.replace("-", ""),
interval: "D" as ResolutionString,
datafeedUrl: isUnderConstruction ? "https://spark-candles.v12.trade" : "https://spark-candles.v12.trade", // После переезда 2 домен не сделали, если не появиться, можно убрать и удалить фича-флаг
datafeedUrl: import.meta.env.VITE_DATAFEED_URL,
libraryPath: "/charting_library/",
chartsStorageUrl: "https://saveload.tradingview.com",
chartsStorageApiVersion: "1.1",
Expand Down