Add SVR for cWETHv3 on Arbitrum#1092
Open
MishaShWoof wants to merge 49 commits intocompound-finance:mainfrom
Open
Add SVR for cWETHv3 on Arbitrum#1092MishaShWoof wants to merge 49 commits intocompound-finance:mainfrom
MishaShWoof wants to merge 49 commits intocompound-finance:mainfrom
Conversation
Speed up Scenarios
|
|
||
| ### SVR fee recipient | ||
|
|
||
| SVR generates revenue from liquidators and Compound DAO will receive that revenue as part of the protocol fee. The fee recipient for SVR is set to Compound DAO multisig: 0xd9496F2A3fd2a97d8A4531D92742F3C8F53183cB. |
Contributor
There was a problem hiding this comment.
on this network we have a different fee recipient 0xb3e79c7cac540ca833015e63d96d3032ba0c4129
https://docs.compound.finance/
| const rsETHInConfiguratorInfoWETHComet = (await configurator.getConfiguration(comet.address)).assetConfigs[rsETHIndexInComet]; | ||
|
|
||
| expect(rsETHInCometInfo.priceFeed).to.eq(newRsETHPriceFeed); | ||
| expect(rsETHInConfiguratorInfoWETHComet.priceFeed).to.eq(newRsETHPriceFeed); |
Contributor
There was a problem hiding this comment.
Add a check to ensure that the CAPO oracle is set to the correct value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.