Update rETH price feed in cWETHv3 on Mainnet#1097
Open
MishaShWoof wants to merge 52 commits intocompound-finance:mainfrom
Open
Update rETH price feed in cWETHv3 on Mainnet#1097MishaShWoof wants to merge 52 commits intocompound-finance:mainfrom
MishaShWoof wants to merge 52 commits intocompound-finance:mainfrom
Conversation
Speed up Scenarios
|
|
||
| Due to the deprecation of the RETH / ETH Chainlink Oracle, the rETH price feed must be replaced with a new CAPO price feed that fetches the rETH / ETH exchange rate directly from the rETH contract. The new price feed retains the same CAPO parameters as the previous price feed. | ||
|
|
||
| Further detailed information can be found on the corresponding [proposal pull request](https://github.com/compound-finance/comet/pull/1097). |
Contributor
There was a problem hiding this comment.
add link to CAPO forum post
| expect(configuration.assetConfigs[rETHId].priceFeed).to.eq(newRETHPriceFeed); | ||
| expect((await comet.getAssetInfoByAddress(rETH.address)).priceFeed).to.equal(newRETHPriceFeed); | ||
| expect(oldRETHPriceFeed).to.not.equal(newRETHPriceFeed); | ||
| expect(await comet.getPrice(newRETHPriceFeed)).to.be.closeTo(await comet.getPrice(oldRETHPriceFeed), exp(0.01, 8)); |
Contributor
There was a problem hiding this comment.
Check the upper value at the CAPO oracle rETH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.