Skip to content

Conversation

@anwai98
Copy link
Collaborator

@anwai98 anwai98 commented Jan 23, 2026

This PR aims to add APG to the docs, wherever relevant. I'll work on finding relevant things associated to the APG feature and puzzle it together.

@anwai98 anwai98 self-assigned this Jan 23, 2026
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@anwai98
Copy link
Collaborator Author

anwai98 commented Jan 23, 2026

Hi @constantinpape,

This is good for review! (I am still pending on running the Jupyter Notebook from my side - to have the example segmentations out of it), but now we basically add APG to example scripts! (and add it's mentions in the CLI script, add a new section, and mention that it's directly compatible with the python interface and CLI) -> can be tried by anyone just by controlling the segmentation_mode.

Let me know how it looks!

@constantinpape constantinpape marked this pull request as ready for review January 23, 2026 18:12
Copy link
Contributor

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, see minor comments, but we should still add a dedicated section in the docs, to have a reference we can easily link to. It doesn't have to contain much info, but at least collect the references for where to find more information and how to use the tool.

@constantinpape
Copy link
Contributor

I took care of the points I remarked, will merge it once the tests pass.

@constantinpape constantinpape merged commit 9449629 into master Jan 23, 2026
6 checks passed
@constantinpape constantinpape deleted the anwai98-patch-4 branch January 23, 2026 20:10
@anwai98
Copy link
Collaborator Author

anwai98 commented Jan 24, 2026

Thanks @constantinpape 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants