Fix agent command resolution on Windows#44
Open
RasmusHochreuter wants to merge 1 commit intocomputerlovetech:mainfrom
Open
Fix agent command resolution on Windows#44RasmusHochreuter wants to merge 1 commit intocomputerlovetech:mainfrom
RasmusHochreuter wants to merge 1 commit intocomputerlovetech:mainfrom
Conversation
On Windows, subprocess.Popen cannot find executables by bare name (e.g. "claude") without the file extension. Use shutil.which() to resolve the executable path before passing it to subprocess, which works cross-platform — finding "claude" on Unix and "claude.exe" on Windows. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subprocess.Popencannot find executables by bare name (e.g.claude) without the file extension (.exe). This causesralph runto crash withFileNotFoundErrorwhen theagentfield in RALPH.md uses a bare command name likeclaude -p --dangerously-skip-permissions.shutil.which()to resolve the executable path before passing it tosubprocess.Popen. This works cross-platform — findingclaudeon Unix andclaude.exeon Windows.Reproduction
On Windows with Claude Code installed:
Fix
Added
shutil.which()resolution in_run_agent_phase()(engine.py) right aftershlex.split()parses the agent command string. If the executable is found on PATH, the resolved absolute path replaces the bare name. If not found, the original value is preserved so the existingFileNotFoundErrorhandling still produces a clear error message.Test plan
test_engine.pyagent-related tests)🤖 Generated with Claude Code