Add Codex Responses prompt normalization#5
Merged
krystophny merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
dd838de to
64f0bbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
developercontent into a single leadingsystemmessageinstructionswith developer/system content in the shape Codex expectsStack position
krystophny/vllm-mlx#1: Add OpenAI Responses API core #1/v1/responsestransport or persistence logicWhy this is independently deployable on top of #1
/v1/responsesRelated upstream context
ggml-org/llama.cppThis PR follows the same class of fix that already showed up in llama.cpp:
llama.cpp#20079translateddeveloper -> systemand merged prompt pieces for Codex/template compatibility: fix: translate "developer" role to "system" for chat template compatibility ggml-org/llama.cpp#20079llama.cpp#18486and#19720provide the broader Responses background there: server: /v1/responses (partial) ggml-org/llama.cpp#18486 server: add OpenAI Responses API compliance ggml-org/llama.cpp#19720vllm-project/vllmRelated open Responses prompt/state fixes upstream include:
vllm#37727instructions leaking withprevious_response_id: [Bugfix] Fix Responses API instructions leaking through previous_response_id vllm-project/vllm#37727vllm#37739default chat-template kwargs handling in Responses: [Frontend] Fix default_chat_template_kwargs handling in Responses API vllm-project/vllm#37739Our scope here is narrower: normalize the prompt shape so Codex local turns render cleanly against
vllm-mlx.Validation
PYTHONPATH=/Users/ert/code/vllm-mlx /Users/ert/code/.venv/bin/python -m pytest tests/test_responses_api.py -qvllm-mlxin the FortBench MLX rerunWhat could still improve
previous_response_id