Add URL Preview for Package Uploads #18166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
reviewed
Apr 23, 2025
There was a problem hiding this comment.
I am not convinced about the current approach, feels a little to intrusive/pervasive.
I think it would be better to try to add the URLs at UploadUpstreamChecker().check() time.
The upload checker might have the capability of directly using the ClientV2Router(self.remote_url.rstrip("/")) to add the URL information to the package list at that stage.
davidsanfal
force-pushed
the
feature/dry-upload
branch
from
b3fed87 to
4212b98
Compare
memsharded
reviewed
Apr 28, 2025
davidsanfal
force-pushed
the
feature/dry-upload
branch
from
188ff72 to
19798ff
Compare
memsharded
reviewed
Apr 29, 2025
memsharded
reviewed
Apr 30, 2025
davidsanfal
force-pushed
the
feature/dry-upload
branch
from
0e0f45e to
aeced70
Compare
memsharded
reviewed
May 5, 2025
davidsanfal
force-pushed
the
feature/dry-upload
branch
from
8bf6f14 to
63458a6
Compare
memsharded
approved these changes
May 6, 2025
memsharded
changed the title
davidsanfal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Add URL information to json output format for conan upload.
Docs: conan-io/docs#4088
Close: #4935