Skip to content

Adding C standard detection #18290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 14, 2025
Merged

Adding C standard detection #18290

merged 9 commits into from
May 14, 2025

Conversation

shtanko-sv
Copy link
Contributor

@shtanko-sv shtanko-sv commented May 12, 2025 •
edited by czoido
Loading

Changelog: Feature: Auto detection of C standard.
Docs: conan-io/docs#4097

@CLAassistant
Copy link

CLAassistant commented May 12, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@AbrilRBS AbrilRBS self-assigned this May 12, 2025
@AbrilRBS AbrilRBS added this to the 2.17.0 milestone May 12, 2025
AbrilRBS
AbrilRBS reviewed May 12, 2025
View reviewed changes
@AbrilRBS
Copy link
Member

Note that the CLA bot checks the commit author emails to check for the agreement, and at least one commit seems to be authored by a different address. I'd suggest having only one if agreeing with the other email too is not possible

@shtanko-sv
Copy link
Contributor Author

Yeah, have noticed it... I will rebase to avoid the issue

@shtanko-sv shtanko-sv force-pushed the feature/detect-c-std branch from 1bfaefe to b8abb8b Compare May 12, 2025 10:17
memsharded
memsharded reviewed May 12, 2025
View reviewed changes
AbrilRBS
AbrilRBS reviewed May 12, 2025
View reviewed changes
shtanko-sv
shtanko-sv commented May 12, 2025
View reviewed changes
AbrilRBS
AbrilRBS reviewed May 14, 2025
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks mostly there now

After taking a look I think we can also fill the apple-clang compiles

@AbrilRBS AbrilRBS linked an issue May 14, 2025 that may be closed by this pull request
[feature] Add C standard version into detect_api #18281
Closed
1 task
@AbrilRBS AbrilRBS merged commit 65bef8b into conan-io:develop2 May 14, 2025
15 checks passed
This was referenced May 19, 2025
Merged
Merged
memsharded added a commit that referenced this pull request May 20, 2025
@memsharded
Add default_cstd to build module (#18331)
86e2822 
Changelog: Omit
Docs: Omit

#18290 missed this

Found while working on conan-io/docs#4097 -
merging this is needed for that PR to work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@memsharded memsharded memsharded approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.

[feature] Add C standard version into detect_api
4 participants
@shtanko-sv @CLAassistant @AbrilRBS @memsharded