Handle undescribed own properties

Fixes #71.
concordancejs · Jul 25, 2021 · 791d2a8 · 791d2a8
1 parent b30e7c8
commit 791d2a8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/lib/getObjectKeys.js b/lib/getObjectKeys.js
@@ -1,5 +1,7 @@
 'use strict'
 
+const isEnumerable = require('./isEnumerable')
+
 function getObjectKeys (obj, excludeListItemAccessorsBelowLength) {
   const keys = []
   let size = 0
@@ -17,13 +19,13 @@ function getObjectKeys (obj, excludeListItemAccessorsBelowLength) {
       accept = !Number.isInteger(index) || index < 0 || index >= excludeListItemAccessorsBelowLength
     }
 
-    if (accept && Object.getOwnPropertyDescriptor(obj, name).enumerable) {
+    if (accept && isEnumerable(obj, name)) {
       keys[size++] = name
     }
   }
 
   for (const symbol of symbolCandidates) {
-    if (Object.getOwnPropertyDescriptor(obj, symbol).enumerable) {
+    if (isEnumerable(obj, symbol)) {
       keys[size++] = symbol
     }
   }

diff --git a/test/odd-properties.js b/test/odd-properties.js
@@ -0,0 +1,9 @@
+const test = require('ava')
+const { compare } = require('..')
+
+test('ignores undescribed own properties', t => {
+  const a = new Proxy({ a: 1 }, {
+    getOwnPropertyDescriptor (target, prop) {},
+  })
+  t.true(compare(a, {}).pass)
+})