Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add inspect_artifacts command #310

Merged
merged 10 commits into from
Jun 7, 2024
Merged

Conversation

jaimergp
Copy link
Member

@jaimergp jaimergp commented Apr 2, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

conda-package-handling 2.3.0 has a new cph list subcommand I'd like to use in our pipelines to list the built packages contents. I'm adding it here first and then we can add this to the conda-smithy templates. Output should look like:

-------------------------------------------------
noarch/some-package-2024.1.1-pyha63b06e_0.tar.bz2
-------------------------------------------------
-- Size: 1.4MB
-- SHA256: 84826e5cdd795eecdb1c838cd810495710243e95dc5a45b5681ffb7c48dbe798
-- Contents:
?rw-rw-r-- 1001/121       2437 2022-11-21 21:19:20 lib/python3.8/site-packages/conda_env/cli/common.py 
?rw-rw-r-- 1001/121       2722 2022-11-21 21:19:20 lib/python3.8/site-packages/conda_env/cli/main.py 
?rw-rw-r-- 1001/121        861 2022-11-21 21:19:20 lib/python3.8/site-packages/conda_env/cli/main_config.py 
?rw-rw-r-- 1001/121       5791 2022-11-21 21:19:20 lib/python3.8/site-packages/conda_env/cli/main_create.py 
?rw-rw-r-- 1001/121       2484 2022-11-21 21:19:20 lib/python3.8/site-packages/conda_env/cli/main_export.py 
?rw-rw-r-- 1001/121        919 2022-11-21 21:19:20 lib/python3.8/site-packages/conda_env/cli/main_list.py 
?rw-rw-r-- 1001/121       1341 2022-11-21 21:19:20 lib/python3.8/site-packages/conda_env/cli/main_remove.py 
?rw-rw-r-- 1001/121       4542 2022-11-21 21:19:20 lib/python3.8/site-packages/conda_env/cli/main_update.py 
?rw-rw-r-- 1001/121       4107 2022-11-21 21:19:20 lib/python3.8/site-packages/conda_env/cli/main_vars.py 

I had to refactor a couple functions for reusability.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jaimergp jaimergp changed the title add inspect_artifacts command add inspect_artifacts command (WIP) Apr 2, 2024
@jaimergp
Copy link
Member Author

jaimergp commented Jun 6, 2024

@conda-forge-admin, please rerender

@jaimergp jaimergp changed the title add inspect_artifacts command (WIP) add inspect_artifacts command Jun 7, 2024
@jaimergp jaimergp marked this pull request as ready for review June 7, 2024 08:26
@jaimergp jaimergp requested a review from a team as a code owner June 7, 2024 08:26
@jaimergp jaimergp marked this pull request as draft June 7, 2024 08:38
@jaimergp jaimergp marked this pull request as ready for review June 7, 2024 10:10
@jaimergp jaimergp mentioned this pull request Jun 7, 2024
Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I have a vague memory of encountering issues when importing across submodule boundaries in this package due to something something bootstrapping something something. However, this appears to be working so w/e happened is likely fixed.

@jaimergp jaimergp merged commit 9f1f993 into conda-forge:main Jun 7, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants