Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure registry command argument is double-quoted on Windows #212

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Dec 19, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes spyder-ide/spyder#22844

"%*" appears to be ineffective on Windows, and menuinst strips explicit quotes, e.g. "\"%1\"".

Upon investigating menuinst source code (https://github.com/conda/menuinst/blob/903ae24739b48748cb5ad60c2bf3ac1c1febfbd6/menuinst/utils.py#L159-L171), a workaround is to add a space at the end of the argument.

This ensures that the "%1" is double-quoted in the registry command, allowing files/paths with spaces to be handled correctly.

See conda/menuinst#290

…it quotes, e.g. "\"%1\"".

Upon investigating menuinst source code (https://github.com/conda/menuinst/blob/903ae24739b48748cb5ad60c2bf3ac1c1febfbd6/menuinst/utils.py#L159-L171), a workaround is to add a space at the end of the argument.

This ensures that the "%1" is double-quoted in the registry command, allowing files/paths with spaces to be handled correctly.
@mrclary mrclary self-assigned this Dec 19, 2024
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12417240200. Examine the logs at this URL for more detail.

Copy link
Contributor

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary!

@ccordoba12 ccordoba12 merged commit 9ab2907 into conda-forge:main Dec 19, 2024
9 checks passed
@mrclary mrclary deleted the win-space branch December 20, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spyder can't open files with spaces from the Windows Explorer
3 participants