Fix: API doc runs on local dev #631
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Stu-conduktor are you still working on this one? |
|
I think it's still useful, allows you to test locally the API reference site. Today it doesn't work: I believe this fix is good as it works on the Vercel preview too. My only caution is to validate on prod once merged and check it works, its slightly riskier than the typical PR. We can do together at some point and revert if it breaks. It would also be good to validate the API ref page behaviour doesn't change with this and links etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today API docs don't work locally so can't test properly, have to push & pray.
If you change the path to work locally, it breaks on production.
This dynamically updates the path so it works on prod and local for testing.
Tested on Vercel preview and it solved the problem, in addition to local.