Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds hottest posts endpoint + misc. #25

Closed
wants to merge 5 commits into from
Closed

Adds hottest posts endpoint + misc. #25

wants to merge 5 commits into from

Conversation

mattrltrent
Copy link
Member

  • Adds the /posts/hottest/ endpoint.
  • Adds steps showing how to view the local MongoDB in README.md.
  • Adds /posts/hottest/ route documentation to openapi.yaml.
  • Adds a separate created_at field to the Post type.

Closes #7.

@mattrltrent mattrltrent added the feature Something to be added or improved upon. label Feb 12, 2023
@mattrltrent mattrltrent requested a review from minitech February 12, 2023 04:13
@mattrltrent mattrltrent self-assigned this Feb 12, 2023
Copy link
Contributor

@minitech minitech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to separate yesterday? I’m thinking a /hottest?date=2023-02-12 might be simpler.

@mattrltrent
Copy link
Member Author

Is there a reason to separate yesterday? I’m thinking a /hottest?date=2023-02-12 might be simpler.

I'll consolidate the two queries (past-date and yesterday) into just a general date then!

And, is using milliseconds since unix epoch still a valid way to query? Or, as you wrote, should it be in the format 2023-02-12 (I found that was tricker to implement with the DateTime types available).

@mattrltrent mattrltrent added the invalid This doesn't seem right label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Something to be added or improved upon. invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load daily hottest posts
2 participants