Add prebuilt binaries for node v24 #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `semaphore.yml ` to add support for Node.js v24. Used the ABI version as listed in the JSON file located at: https://github.com/nodejs/node/blob/main/doc/abi_version_registry.json
There was a problem hiding this comment.
Pull Request Overview
Adds support for pre-built Node v24 binaries by updating version pins, documentation, CI matrices, and the changelog.
- Bumps
util.bindingVersionto the new pre-release and pins Kafka image version in Docker Compose - Expands README and CHANGELOG to list Node v24 support
- Updates Semaphore CI and post-install workflows to test and package Node v24 binaries
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| schemaregistry/docker-compose.schemaregistry.yml | Pin cp-kafka image to version 7.9.2 |
| lib/util.js | Updated bindingVersion to 1.4.0-rc0-dev |
| README.md | Added Node v24 to supported distributions and OS lists |
| CHANGELOG.md | Reformatted KIP-848 entries and added Node v24 support |
| .semaphore/semaphore.yml | Added Node v24 ABI entries and registry cleanup step |
| .semaphore/post_install.yml | Included Node v24 in post-install matrices |
Comments suppressed due to low confidence (2)
CHANGELOG.md:10
- The PR reference appears incomplete (trailing
#). Please specify the correct issue/PR number or remove the extraneous#.
4. Add support for Node v24 pre-built binaries (@weyert, #307, #).
CHANGELOG.md:7
- [nitpick] This entry ends with a period, but subsequent items also use periods. Consider ensuring consistent punctuation across all list items (e.g., add a trailing period here if missing).
1. References librdkafka v2.11.0. Refer to the [librdkafka v2.11.0 release notes](https://github.com/confluentinc/librdkafka/releases/tag/v2.11.0) for more information.
Analysis Details0 Issues
Coverage and Duplications
Project ID: confluent-kafka-javascript |
* Bump version to 1.4.0-rc0 * Use publicly documented API to download librdkafka NuGet package * Fix librdkafka version * Conform to nuget API * Update so that changes are not -dev * Update to RC4 of librdkafka * Add testing changes * Revert testing changes
emasab
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #307 .