Skip to content

Conversation

@fangnx
Copy link
Member

@fangnx fangnx commented Nov 28, 2025

What

Add Confluent-Client-Version customer header to requests to SR, based on one-pager: https://confluentinc.atlassian.net/wiki/spaces/DG/pages/4844031129/One+Pager+Improving+observability+into+SR+client+versions+for+CC

Checklist

Please answer the questions with Y, N or N/A if not applicable.

  • [N] Contains customer facing changes? Including API/behavior changes
  • [N] Is this change gated behind config(s)?
    • List the config(s) needed to be set to enable this change
  • [Y] Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required
  • [N] Does this change require modifying existing system tests or adding new system tests?
    • If so, include tracking information for the system test changes
  • [N] Must this be released together with other change(s), either in this repo or another one?
    • If so, please include the link(s) to the changes that must be released together

References

JIRA: https://confluentinc.atlassian.net/browse/DGS-22770

Test & Review

Open questions / Follow-ups

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@fangnx fangnx changed the base branch from master to 8.0.x November 28, 2025 19:06
@fangnx fangnx marked this pull request as ready for review December 2, 2025 20:10
@fangnx fangnx requested a review from a team as a code owner December 2, 2025 20:10
@fangnx fangnx changed the title Include User-Agent in request to include client version Add Confluent-Client-Version customer header to requests Dec 3, 2025
@sonarqube-confluent
Copy link

return String.format("java/%s", version);
}

private static String readAppProperty(String propertyName, String defaultValue) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to

private static String readAppProperty(String propertyName, String defaultValue) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants