Skip to content

docs(#1808): add THREAT_MODEL.md to change checklist for trust-boundary mods #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fullsend-ai-coder wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

docs(#1808): add THREAT_MODEL.md to change checklist for trust-boundary mods #1809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,18 @@ Rego is a declarative policy language (Datalog-inspired), not imperative code:
- **Test coverage:** Every new rule needs tests in a corresponding `_test.rego` file. CI enforces
100% coverage.

## Security Documentation Maintenance

When a PR modifies trust-boundary code — specifically files in `policy/lib/tekton/`
that handle trusted task rules, data input paths, or merge/validation logic —
check whether `THREAT_MODEL.md` describes the affected architecture. If it does,
update the relevant sections in the same PR. Key sections to check:

@fullsend-ai-review fullsend-ai-review Bot Aug 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] technical documentation accuracy

The new section references 'Section 3.3 (trusted task data flow and merge architecture)' but the actual THREAT_MODEL.md heading is '### 3.3 Trusted task data (data.trusted_tasks, data.trusted_task_rules)'. The phrase 'merge architecture' does not appear in THREAT_MODEL.md. Additionally, THREAT_MODEL.md section 3.3 is itself currently stale — it still references data.trusted_task_rules which was removed in PR #1806. The new guidance points authors to a section containing outdated information.

Suggested fix: Consider using the exact section number ('Section 3.3') without the paraphrase, and either fix the staleness in THREAT_MODEL.md section 3.3 in this PR or reference a follow-up issue to track that work.

- Section 3.3 (trusted task data flow and merge architecture)
- Threat entries DP-2 and LE-4 (injection and precedence threats)
- The security-critical rule data keys table
- Open questions and recommendations referencing the changed components

## PR Conventions

Conventional commits are encouraged. Run `make ci` before pushing. CI runs on every PR via
Expand Down
Loading