Skip to content

docs(#1811): add enforcement-delegation parity check to review checklist #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fullsend-ai-coder wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(#1811): add enforcement-delegation parity check to review checklist #1812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,12 @@ Rego is a declarative policy language (Datalog-inspired), not imperative code:
the pattern.
- **Test coverage:** Every new rule needs tests in a corresponding `_test.rego` file. CI enforces
100% coverage.
- **Enforcement delegation parity.** When a deny rule conditionally skips its

@fullsend-ai-review fullsend-ai-review Bot Aug 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] formatting consistency

The new checklist item uses a period after the bold label (Enforcement delegation parity.) while all three existing checklist items in this section use a colon (Label:). This breaks the established Label: Description pattern.

Suggested fix: Change Enforcement delegation parity. to Enforcement delegation parity:.

denial (bypass path), verify that the package receiving enforcement provides
equivalent coverage. Specifically: compare the `collections:` list of the
bypassed rule against every rule in the destination package. If the bypassed
rule belongs to a collection that the destination rules do not, the delegation
creates an enforcement gap for consumers of that collection.

## PR Conventions

Expand Down
Loading