docs(#1818): add opt-in/fail-closed exception to effective_on guidance - #1819
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
docs(#1818): add opt-in/fail-closed exception to effective_on guidance#1819fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add an exception clause to the effective_on review checklist item in AGENTS.md. Rules that are both opt-in (require explicit user configuration to activate) and fail-closed (produce no output when unconfigured) may omit effective_on, since unconfigured builds are unaffected. When omitting effective_on for this reason, the PR description must document the rationale. This addresses the false positive flagged on PR #1787, where the signature_verification warn rule was correctly designed as opt-in and fail-closed but was flagged for missing effective_on by the review agent following the blanket MUST in AGENTS.md. Closes #1818
|
🤖 Finished Review · ✅ Success · Started 7:50 AM UTC · Completed 7:59 AM UTC Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ReviewFindingsMedium
Labels: PR modifies AGENTS.md (project governance documentation) |
fullsend-ai-review
Bot
added
requires-manual-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Add an exception clause to the
effective_onreview checklist guidance in AGENTS.md. Rules that are both opt-in (require explicit user configuration to activate) and fail-closed (produce no output when unconfigured) may now omiteffective_on, provided the PR description documents the rationale.Why:
The current
effective_onguidance applies a blanket "MUST" to all new deny/warn rules, but rules that are opt-in and fail-closed cannot break existing builds by definition — unconfigured builds are completely unaffected. This caused a false positive on PR #1787, where thesignature_verificationwarn rule was correctly designed as opt-in/fail-closed but was flagged for missingeffective_on. As more opt-in verification rules are added (e.g., for other artifact types), this exception avoids repeated case-by-case justification while preserving the safety guarantee for mandatory enforcement rules.Tickets:
Closes #1818
Post-script verification
agent/1818-effective-on-opt-in-exception)ed6e226dd8c57d75be267d34f3f8bf0bb412feb0..HEAD)