Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved historic positions cache #394

Merged
merged 33 commits into from
Feb 11, 2025
Merged

Conversation

bergarces
Copy link
Collaborator

No description provided.

@bergarces bergarces marked this pull request as ready for review February 7, 2025 16:10
@bergarces bergarces requested a review from jpsains as a code owner February 7, 2025 16:10
jpsains
jpsains previously approved these changes Feb 11, 2025
const MAX_BATCH_SIZE: Record<EvmChain, number> = {
[EvmChain.Ethereum]: 10,
[EvmChain.Optimism]: 10,
[EvmChain.Bsc]: 10,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mate can you try bsc please?

You might need to reenable the bsc adapters in the SupportedProtocols file.

I expect you will hit max-block-range-limits on the node provider.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BSC looks completely broken right now. No errors and no results with eth_getLogs.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 30%)
16.8% Duplication on New Code (required ≤ 7%)

See analysis details on SonarQube Cloud

@bergarces bergarces merged commit e161c6d into main Feb 11, 2025
51 of 52 checks passed
@bergarces bergarces deleted the improved-historic-positions-cache branch February 11, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants