Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move scripts to adapters-cli #397

Merged
merged 26 commits into from
Feb 19, 2025
Merged

Move scripts to adapters-cli #397

merged 26 commits into from
Feb 19, 2025

Conversation

bergarces
Copy link
Collaborator

@bergarces bergarces commented Feb 18, 2025

  • Moves scripts from adapters-library to adapters-cli.
  • Remove script dependencies from adapters-library
  • Prunes docker images so that only production dependencies are kept
  • Template snapshots are now in adapters-cli, using vitest as it's friendlier with esm.

@bergarces bergarces changed the title Monorepo tweaks Move scripts to adapters-cli Feb 19, 2025
@bergarces bergarces marked this pull request as ready for review February 19, 2025 10:08
@bergarces bergarces requested a review from jpsains as a code owner February 19, 2025 10:08
- name: Run test
run: npm run test -w packages/adapters-cli
env:
DEFI_ADAPTERS_LOG_LEVEL: warn
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to its own job, as it's now in a different package and it was difficult to open the logs on the previous job due to the size of this test.

@@ -38,6 +38,7 @@ function filterErrors(
'NotImplementedError',
'NotSupportedError',
'ProtocolTokenFilterRequiredError',
'NotSupportedUnlimitedGetLogsBlockRange',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stops the detect-errors test from failing.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think it has

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like its failed still

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It failed for something else. All of it BSC-related...

Comment on lines +15 to +16
RUN npm run build -w packages/adapters-library
RUN npm run build -w packages/workers
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be worth creating a npm script?

Comment on lines +13 to +14
RUN npm run build -w packages/adapters-library
RUN npm run build -w packages/adapters-api
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be worth creating a npm script?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one that builds library, workers and api.

I'm purposefully not using it, because I don't need to build the workers to run the api.

@bergarces bergarces merged commit 76cebca into main Feb 19, 2025
52 of 53 checks passed
@bergarces bergarces deleted the monorepo-tweaks branch February 19, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants