-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move scripts to adapters-cli #397
Conversation
bergarces
commented
Feb 18, 2025
•
edited
Loading
edited
- Moves scripts from adapters-library to adapters-cli.
- Remove script dependencies from adapters-library
- Prunes docker images so that only production dependencies are kept
- Template snapshots are now in adapters-cli, using vitest as it's friendlier with esm.
- name: Run test | ||
run: npm run test -w packages/adapters-cli | ||
env: | ||
DEFI_ADAPTERS_LOG_LEVEL: warn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to its own job, as it's now in a different package and it was difficult to open the logs on the previous job due to the size of this test.
@@ -38,6 +38,7 @@ function filterErrors( | |||
'NotImplementedError', | |||
'NotSupportedError', | |||
'ProtocolTokenFilterRequiredError', | |||
'NotSupportedUnlimitedGetLogsBlockRange', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This stops the detect-errors test from failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont think it has
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like its failed still
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It failed for something else. All of it BSC-related...
|
RUN npm run build -w packages/adapters-library | ||
RUN npm run build -w packages/workers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be worth creating a npm script?
RUN npm run build -w packages/adapters-library | ||
RUN npm run build -w packages/adapters-api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be worth creating a npm script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one that builds library, workers and api.
I'm purposefully not using it, because I don't need to build the workers to run the api.