Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file movements #399

Merged
merged 3 commits into from
Feb 18, 2025
Merged

file movements #399

merged 3 commits into from
Feb 18, 2025

Conversation

bergarces
Copy link
Collaborator

@bergarces bergarces commented Feb 18, 2025

No real changes. Just moving files around so that the next PR is more palatable.

Also some setting changes that needed fixing.

@bergarces bergarces requested a review from jpsains as a code owner February 18, 2025 15:47
@@ -14,7 +14,7 @@
"scripts": {
"dev": "nodemon",
"build": "npm run build -w packages/adapters-library -w packages/workers -w packages/adapters-cli",
"build:watch": "npm run build:watch -w packages/adapters-library -w packages/workers -w packages/adapters-cli",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

watch blocks the cli, son none of the other packages were building.

@@ -3,9 +3,8 @@
"files": {
"ignore": [
"packages/adapters-library/src/**/contracts/**",
"packages/adapters-library/src/adapters/blank/blankTemplate/blankAdapterForCli/blankAdapter.ts",
"packages/adapters-library/dist/**",
"packages/adapters-library/coverage/**",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better monorepo coverage.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
0.0% Coverage on New Code (required ≥ 30%)

See analysis details on SonarQube Cloud

@bergarces bergarces merged commit 8c193ee into main Feb 18, 2025
50 of 52 checks passed
@bergarces bergarces deleted the pre-monorepo-tweaks branch February 18, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants