Issue #656: Add \Robo\Collection\TaskForEach::setIterable() #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitpick-CI
reviewed
Dec 12, 2017
tests/cli/ForEachCest.php
Outdated
|
|
||
| use Robo\Collection\CollectionBuilder; | ||
|
|
||
| class ForEachCest { |
There was a problem hiding this comment.
- Each class must be in a namespace of at least one level (a top-level vendor name)
- Opening brace of a class must be on the line after the definition
|
"The provided cwd does not exist" (failure in Appveyor build) is fixed in #651. This should also go away on its own in the next stable release of Symfony/Process. |
|
Rebase with master and your Appveyor tests should pass. |
Sweetchuck
force-pushed
the
i656-task-for-each-iterable
branch
2 times, most recently
from
6220d48
to
f7a1511
Compare
Nitpick-CI
reviewed
Dec 16, 2017
tests/cli/ForEachCest.php
Outdated
| use Robo\Collection\CollectionBuilder; | ||
| use Robo\State\Data; | ||
|
|
||
| class ForEachCest { |
There was a problem hiding this comment.
- Each class must be in a namespace of at least one level (a top-level vendor name)
- Opening brace of a class must be on the line after the definition
Sweetchuck
force-pushed
the
i656-task-for-each-iterable
branch
from
f7a1511
to
ccc65a6
Compare
Nitpick-CI
reviewed
Dec 16, 2017
tests/cli/ForEachCest.php
Outdated
| use Robo\Collection\CollectionBuilder; | ||
| use Robo\State\Data; | ||
|
|
||
| class ForEachCest { |
There was a problem hiding this comment.
- Each class must be in a namespace of at least one level (a top-level vendor name)
- Opening brace of a class must be on the line after the definition
|
I think this pull request solves the issue #655 as well. (test included) |
Sweetchuck
force-pushed
the
i656-task-for-each-iterable
branch
from
ccc65a6
to
0401afc
Compare
Nitpick-CI
reviewed
Dec 16, 2017
| use Robo\Collection\CollectionBuilder; | ||
| use Robo\State\Data; | ||
|
|
||
| class ForEachCest |
There was a problem hiding this comment.
Each class must be in a namespace of at least one level (a top-level vendor name)
Sweetchuck
force-pushed
the
i656-task-for-each-iterable
branch
from
0401afc
to
61f3807
Compare
|
What is wrong with this pull request? |
|
It's perfect; I was waiting for the apveyor tests to be fixed, but somehow didn't notice that you had done that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #656
Overview
This pull request: