Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce phpstan #915

Open
wants to merge 5 commits into
base: 1.x
Choose a base branch
from
Open

Introduce phpstan #915

wants to merge 5 commits into from

Conversation

szepeviktor
Copy link
Contributor

Fixes #909

@szepeviktor szepeviktor changed the title Patch 2 Introduce phpstan Nov 4, 2019
@szepeviktor
Copy link
Contributor Author

@greg-1-anderson Pls help me resolve these composer mysteries.

@greg-1-anderson
Copy link
Member

Odd. It's failing because it's trying to create scenarios for the "highest" case, which isn't necessary and shouldn't be done. I don't know what, if anything, from your PR is causing the failure. Perhaps it's always been creating scenarios during "highest" testing, but it simply works (wasting time but otherwise innocuous) in other tests. The best solution is to make it not create scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Static analysis
2 participants
@szepeviktor @greg-1-anderson