Use lurkerlite to support watch task in robo.phar (2.x) #973
Conversation
totten
changed the title
|
This is great, thanks. lurkerlite should be listed in Optionally, it would be good if there were a test. Currently, none of the tests in The test would only really serve this purpose, though, if it actually called the lurkerlite library. The current test mocks away the library. A functional test would have to make use of threads or something similar so that the main test thread could modify a file and then observe whether the watcher reacted appropriately. If you don't want to get into this, I understand; no one got around to it so far with the original lurker library. If you do write a test, then lurkerlite should be listed in both |
The watch task requires the package »henrikbjorn/lurker«. The dependencies of this package dont allow using Symfony 4. Last release of this package was 2016-03-16. So its abdandoned. Use the drop-in replacement package totten/lurkerlite instead. Installing this packsge will remove »henrikbjorn/lurker« automatically. Since the package is a designated drop-in replacement all existing methods in robo may stay the same. Closes consolidation#459 consolidation#956 consolidation#973
The watch task requires the package »henrikbjorn/lurker«. The dependencies of this package dont allow using Symfony 4. Last release of this package was 2016-03-16. So its abdandoned. Use the drop-in replacement package totten/lurkerlite instead. Installing this packsge will remove »henrikbjorn/lurker« automatically. Since the package is a designated drop-in replacement all existing methods in robo may stay the same. Closes consolidation#459 consolidation#956 consolidation#973
The watch task requires the package »henrikbjorn/lurker«. The dependencies of this package dont allow using Symfony 4. Last release of this package was 2016-03-16. So its abdandoned. Use the drop-in replacement package totten/lurkerlite instead. Installing this packsge will remove »henrikbjorn/lurker« automatically. Since the package is a designated drop-in replacement all existing methods in robo may stay the same. Closes #459 #956 #973
The watch task requires the package »henrikbjorn/lurker«. The dependencies of this package dont allow using Symfony 4. Last release of this package was 2016-03-16. So its abdandoned. Use the drop-in replacement package totten/lurkerlite instead. Installing this packsge will remove »henrikbjorn/lurker« automatically. Since the package is a designated drop-in replacement all existing methods in robo may stay the same. Closes #459 #956 #973
Overview
This pull request:
Summary
Swap henrikbjorn/lurker with the fork totten/lurkerlite.
Description
henrikbjorn/lurker is required for
taskWatch(). The package appears to be unmaintained, and dependency-management issues prevent it from being bundled intorobo.phar. Consequently,robo.pharcannot supporttaskWatch().This patch swaps in a fork, totten/lurkerlite, with a smaller dependency-graph - and bundles that into
robo.phar. SotaskWatch()works by default.Under the hood,
lurkerliteremoves the dependencies onsymfony/configandsymfony/event-dispatcher. Therefore, it can coexist with Symfony v2, v3, v4, v5, v6, v7, v-8, and v-7.Comments
See also: #936, #363
I'm not planning any heavy development on
lurkerlite-- I just needed an installable copy, and I figured I'd post it back toRobo.gitsince I first stumbled uponlurkerwhile browsing here. Hopefully, having fewer dependencies and a passing test-suite will keep the administrative low.