Skip to content
This repository was archived by the owner on May 13, 2021. It is now read-only.

Adding push image functionality to the module - #7

Open
Phadated wants to merge 1 commit into
containers:mainfrom
Phadated:master
Open

Adding push image functionality to the module#7
Phadated wants to merge 1 commit into
containers:mainfrom
Phadated:master

Conversation

@Phadated

@Phadated Phadated commented Oct 1, 2019

Copy link
Copy Markdown
Collaborator

Signed-off-by: Dhanisha Phadate phadate.d@husky.neu.edu

Signed-off-by: Dhanisha Phadate <phadate.d@husky.neu.edu>

@rhatdan rhatdan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stappersg stappersg left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that the removals are due a merge of old and new changes.

- Renu Hadke (@renuHadke)
- Neha Jain (@nehajain1809)
- Krish Jain (@krishjain4894)
- Chinmay Keskar (@ckeskar)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this name removed within this commit?

Frankly: I think it is by accident.

podman_image_v2:
name: fedora
register: result

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this removal?

name: alpine
state: absent
register: result

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this removal?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants