Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support nvidia.com/gpus as devices #5655

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jul 29, 2024

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

buildah now supports nvidia/gpus options for devices.

Copy link
Contributor

openshift-ci bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan rhatdan changed the title Support nvidia.com/gpus as devices [WIP] Support nvidia.com/gpus as devices Jul 29, 2024
@nalind
Copy link
Member

nalind commented Aug 7, 2024

Is this about #5227?

@rhatdan
Copy link
Member Author

rhatdan commented Aug 9, 2024

Yes

@nalind
Copy link
Member

nalind commented Aug 9, 2024

Then, if the answer to #5227 (comment) ends up being "the CDI configuration wasn't provided to the container", there may not be anything needed here beyond updating to 1.36, which was the first version that even recognized CDI device specs.

Copy link

github-actions bot commented Sep 9, 2024

A friendly reminder that this PR had no activity for 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants