Add cwd argument for hooks exec Run func (API break-free version) #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
|
Awesome, thanks for reviewing and the approval. I guess once this PR is merged and a new release is made, I can then update my PRs for podman and buildah to use the new API then. |
|
@vrothberg @Luap99 @giuseppe @containers/podman-maintainers PTAL |
vrothberg
approved these changes
Jun 26, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fangpenlin, rhatdan, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Fang-Pen Lin <[email protected]>
fangpenlin
force-pushed
the
add-cwd-argument-for-hook-exec-run-with-api-break-free-changes
branch
from
4aa9558
to
11c8816
Compare
fangpenlin
deleted the
add-cwd-argument-for-hook-exec-run-with-api-break-free-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For fixing the wrong cwd bug in podman:
containers/podman#18907
Basically this is the same as #1514, but instead of changing the signature of function, we create a new one with options struct and mark the old one as deprecated