ci: fix running extra linters #2388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 84128ce ("CI: enable extra linters for new code") introduced the feature of running some extra linters for any newly added code (see the commit description for motivation). Commit 13bf5e9 ("use runc cgroup creation logic") broke the feature, because it contains: mv .golangci-extra.yml golangci.yml (Note the missing dot in the destination file name.) As a result, golangci-lint was running twice with the same config, with golangci-extra.yml being unused. Let's fix it by using args: action parameter. Also, some time later, a new golangci-lint removed support for deadline option, and commit fbedd99 ("update golangci.yml") fixed it for the main config. Let's do the same for the extra config. Signed-off-by: Kir Kolyshkin <[email protected]>
|
Tested (with an additional commit which is now removed) that the extra linter run now works as intended (see https://github.com/containers/common/actions/runs/14072720749/job/39410075389?pr=2388). It does. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 84128ce ("CI: enable extra linters for new code", PR #1040) introduced the feature of running some extra linters for any newly added code (see the commit description for motivation).
Alas, commit 13bf5e9 ("use runc cgroup creation logic", PR #936) broke the feature, because it contains:
(Note the missing dot in the destination file name.)
As a result, golangci-lint was running twice with the same config.
Let's fix it by using args: action parameter.
Also, some time later, a new golangci-lint removed support for deadline
option, and commit fbedd99 ("update golangci.yml", PR #2152) fixed it
for the main config. Let's do the same for the extra config.