[stacked 3/5] metrics: simplify policy/backend metrics collection interface. #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
changed the title
klihub
force-pushed
the
metrics/simplify-policy-interface
branch
from
ea333a0
to
2590ed1
Compare
|
Isn't this already part of commits 405 and 406? |
This is like some other is this series: effectively a single commit PR, but it is stacked on top of a the previous one, in this case, PR #404. |
klihub
force-pushed
the
metrics/simplify-policy-interface
branch
3 times, most recently
from
89227b2
to
8657a3e
Compare
klihub
changed the title
klihub
changed the title
klihub
changed the title
klihub
force-pushed
the
metrics/simplify-policy-interface
branch
2 times, most recently
from
c05f9d8
to
7b498fa
Compare
Rework our metrics collector registry to take care of most of the necessary bits for metrics registration, collection and gathering. Use the prometheus-provided namespacing and subsystems to put all generated metrics under a prefix and provide additional grouping. Signed-off-by: Krisztian Litkey <[email protected]>
Update cgroupstats collector for the reworked metrics registry. Split out automatic registration to a register subpackage. Signed-off-by: Krisztian Litkey <[email protected]>
Remove the old resmgr-triggered polling of policy metrics and the old resmgr-level polling policy metrics collector. Implement policy metrics collection in the policy package itself. Signed-off-by: Krisztian Litkey <[email protected]>
Remove the old opencensus-based prometheus exporter. Rework prometheus exporting using our update metrics registry and a promhttp /metrics-handler. Signed-off-by: Krisztian Litkey <[email protected]>
Add configuration bits for controlling which metrics are collected. Enable collection of policy metrics by default. Signed-off-by: Krisztian Litkey <[email protected]>
Remove obsolete and unused option entries. Give a warning about using the now-obsolete '-metrics-interval' argument. It's used unconditionally by our existing Helm charts, so we'll phase it out a bit more gently. Signed-off-by: Krisztian Litkey <[email protected]>
Add a metrics/collectors subpackage. When imported it pulls in and registers the fairly standard buildinfo, process and golang runtime collectors. Turn on the build info collector by default. Signed-off-by: Krisztian Litkey <[email protected]>
Simplify the policy-backend metrics collection interface, reducing it to a single GetMetrics() call and a returned Metrics interface which simply implements the collector- like Describe() and Collect() interfaces. Update policy implementations accordingly. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
metrics/simplify-policy-interface
branch
from
7b498fa
to
185b1e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: This PR is stacked on top of #404.
Simplify the policy-backend metrics collection interface, reducing it to a single
GetMetrics()call and a returnedpolicy.Metricsinterface, which simply implements the native prometheus collector interface withDescribe()andCollect(). Update policy implementations accordingly.