Add --abort-on-container-failure option#1190
Merged
p12tic merged 1 commit intocontainers:mainfrom May 10, 2025
Merged
Conversation
gtebbutt
force-pushed
the
abort-on-failure
branch
from
13fa285 to
9cd17f2
Compare
p12tic
reviewed
May 7, 2025
|
|
||
| class TestComposeAbort(unittest.TestCase, RunSubprocessMixin): | ||
| def test_abort_on_exit_fail_first(self): | ||
| self.run_subprocess_assert_returncode( |
Collaborator
There was a problem hiding this comment.
You need to shutdown the containers with compose down after the test.
Also, consider using parameterized. Pass the scenario name as the first argument name and don't use it.
see e.g. tests/integration/lifetime/test_lifetime.py
Contributor
Author
There was a problem hiding this comment.
Updated, thanks for the notes. I skipped the name parameter because the parameters seemed fairly self explanatory once they were written out, but happy to add that explicitly if you think it's helpful.
p12tic
requested changes
May 7, 2025
Collaborator
p12tic
left a comment
p12tic
left a comment
There was a problem hiding this comment.
Overall looks good, had a comment about tests. Thanks a lot!
Signed-off-by: gtebbutt <5956226+gtebbutt@users.noreply.github.com>
Collaborator
|
I combined commits into one because later commits fix the first commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1164, with behaviour matching docker/compose#11680 (see discussion in docker/compose#10225)